netdev - Re: [net-next 08/16] net/mlx5e: Add devlink fdb_large

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200228111026.1baa9984@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Fri, 28 Feb 2020 11:10:26 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Saeed Mahameed <saeedm@...lanox.com>
Cc:     "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        Jianbo Liu <jianbol@...lanox.com>,
        Vlad Buslov <vladbu@...lanox.com>,
        Roi Dayan <roid@...lanox.com>, Jiri Pirko <jiri@...lanox.com>
Subject: Re: [net-next 08/16] net/mlx5e: Add devlink fdb_large_groups
 parameter

On Thu, 27 Feb 2020 16:44:38 -0800 Saeed Mahameed wrote:
> From: Jianbo Liu <jianbol@...lanox.com>
> 
> Add a devlink parameter to control the number of large groups in a
> autogrouped flow table. The default value is 15, and the range is between 1
> and 1024.
> 
> The size of each large group can be calculated according to the following
> formula: size = 4M / (fdb_large_groups + 1).
> 
> Examples:
> - Set the number of large groups to 20.
>     $ devlink dev param set pci/0000:82:00.0 name fdb_large_groups \
>       cmode driverinit value 20
> 
>   Then run devlink reload command to apply the new value.
>     $ devlink dev reload pci/0000:82:00.0
> 
> - Read the number of large groups in flow table.
>     $ devlink dev param show pci/0000:82:00.0 name fdb_large_groups
>     pci/0000:82:00.0:
>       name fdb_large_groups type driver-specific
>         values:
>           cmode driverinit value 20
> 
> Signed-off-by: Jianbo Liu <jianbol@...lanox.com>
> Reviewed-by: Vlad Buslov <vladbu@...lanox.com>
> Reviewed-by: Roi Dayan <roid@...lanox.com>
> Acked-by: Jiri Pirko <jiri@...lanox.com>
> Signed-off-by: Saeed Mahameed <saeedm@...lanox.com>

Slicing memory up sounds like something that should be supported via
the devlink-resource API, not by params and non-obvious calculations :(