netdev - Re: [PATCH net] net: dsa: mv88e6xxx: fix lockup on warm boot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200228195247.GH29979@lunn.ch>
Date:   Fri, 28 Feb 2020 20:52:47 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Russell King <rmk+kernel@...linux.org.uk>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        Vivien Didelot <vivien.didelot@...il.com>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH net] net: dsa: mv88e6xxx: fix lockup on warm boot

On Fri, Feb 28, 2020 at 07:39:41PM +0000, Russell King wrote:
> If the switch is not hardware reset on a warm boot, interrupts can be
> left enabled, and possibly pending. This will cause us to enter an
> infinite loop trying to service an interrupt we are unable to handle,
> thereby preventing the kernel from booting.
> 
> Ensure that the global 2 interrupt sources are disabled before we claim
> the parent interrupt.
> 
> Observed on the ZII development revision B and C platforms with
> reworked serdes support, and using reboot -f to reboot the platform.
> 
> Fixes: dc30c35be720 ("net: dsa: mv88e6xxx: Implement interrupt support.")
> Signed-off-by: Russell King <rmk+kernel@...linux.org.uk>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew