netdev - Re: [PATCH net-next v2 1/6] cxgb4/chcr : Register to tls add and del callbacks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200228.122534.2100427304852735810.davem@davemloft.net>
Date:   Fri, 28 Feb 2020 12:25:34 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     rohitm@...lsio.com
Cc:     netdev@...r.kernel.org, herbert@...dor.apana.org.au,
        secdev@...lsio.com, varun@...lsio.com
Subject: Re: [PATCH net-next v2 1/6] cxgb4/chcr : Register to tls add and
 del callbacks

From: Rohit Maheshwari <rohitm@...lsio.com>
Date: Sat, 29 Feb 2020 00:09:40 +0530

> +#ifdef CONFIG_CHELSIO_TLS_DEVICE
> +/* cxgb4_set_ktls_feature: request FW to enable/disable ktls settings.
> + * @adap: adapter info
> + * @enable: 1 to enable / 0 to disable ktls settings.
> + */
> +static void cxgb4_set_ktls_feature(struct adapter *adap, bool enable)
> +{
> +	int ret = 0;
> +	u32 params = (FW_PARAMS_MNEM_V(FW_PARAMS_MNEM_DEV) |
> +		      FW_PARAMS_PARAM_X_V(FW_PARAMS_PARAM_DEV_KTLS_TX_HW) |
> +		      FW_PARAMS_PARAM_Y_V(enable));
> +	ret = t4_set_params(adap, adap->mbox, adap->pf, 0, 1, &params, &params);
> +	/* if fw returns failure, clear the ktls flag */
> +	if (ret)
> +		adap->params.crypto &= ~ULP_CRYPTO_KTLS_INLINE;

Please put an empty line between local variable declarations and code.

Please order local variables in reverse christmas tree ordering.

Thank you.