netdev - Re: [PATCH] ip route: Do not imply pref and ttl-propagate are per nexthop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200228134706.38c873cf@hermes.lan>
Date:   Fri, 28 Feb 2020 13:47:06 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Donald Sharp <sharpd@...ulusnetworks.com>
Cc:     netdev@...r.kernel.org, dsahern@...nel.org,
        roopa@...ulusnetworks.com
Subject: Re: [PATCH] ip route: Do not imply pref and ttl-propagate are per
 nexthop

On Tue, 25 Feb 2020 08:12:13 -0500
Donald Sharp <sharpd@...ulusnetworks.com> wrote:

> Currently `ip -6 route show` gives us this output:
> 
> sharpd@eva ~/i/ip (master)> ip -6 route show
> ::1 dev lo proto kernel metric 256 pref medium
> 4:5::6:7 nhid 18 proto static metric 20
>         nexthop via fe80::99 dev enp39s0 weight 1
>         nexthop via fe80::44 dev enp39s0 weight 1 pref medium
> 
> Displaying `pref medium` as the last bit of output implies
> that the RTA_PREF is a per nexthop value, when it is infact
> a per route piece of data.
> 
> Change the output to display RTA_PREF and RTA_TTL_PROPAGATE
> before the RTA_MULTIPATH data is shown:
> 
> sharpd@eva ~/i/ip (master)> ./ip -6 route show
> ::1 dev lo proto kernel metric 256 pref medium
> 4:5::6:7 nhid 18 proto static metric 20 pref medium
>         nexthop via fe80::99 dev enp39s0 weight 1
>         nexthop via fe80::44 dev enp39s0 weight 1
> 
> Signed-off-by: Donald Sharp <sharpd@...ulusnetworks.com>

Looks good applied