netdev - Re: [PATCH] net: bluetooth: hci_core: Fix Suspicious RCU usage warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <182A4E2D-86AB-4C81-8ACB-AC8033BAFDE3@holtmann.org>
Date:   Fri, 28 Feb 2020 08:37:03 +0100
From:   Marcel Holtmann <marcel@...tmann.org>
To:     madhuparnabhowmik10@...il.com
Cc:     Johan Hedberg <johan.hedberg@...il.com>,
        "David S. Miller" <davem@...emloft.net>, kuba@...nel.org,
        linux-bluetooth@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, joel@...lfernandes.org,
        linux-kernel-mentees@...ts.linuxfoundation.org,
        frextrite@...il.com, paulmck@...nel.org
Subject: Re: [PATCH] net: bluetooth: hci_core: Fix Suspicious RCU usage
 warnings

Hi Madhuparna,

> The following functions in hci_core are always called with
> hdev->lock held. No need to use list_for_each_entry_rcu(), therefore
> change the usage of list_for_each_entry_rcu() in these functions
> to list_for_each_entry().
> 
> hci_link_keys_clear()
> hci_smp_ltks_clear()
> hci_smp_irks_clear()
> hci_blocked_keys_clear()
> 
> Warning encountered with CONFIG_PROVE_RCU_LIST:
> 
> [   72.213184] =============================
> [   72.213188] WARNING: suspicious RCU usage
> [   72.213192] 5.6.0-rc1+ #5 Not tainted
> [   72.213195] -----------------------------
> [   72.213198] net/bluetooth/hci_core.c:2288 RCU-list traversed in non-reader section!!
> 
> [   72.213676] =============================
> [   72.213679] WARNING: suspicious RCU usage
> [   72.213683] 5.6.0-rc1+ #5 Not tainted
> [   72.213685] -----------------------------
> [   72.213689] net/bluetooth/hci_core.c:2298 RCU-list traversed in non-reader section!!
> 
> [   72.214195] =============================
> [   72.214198] WARNING: suspicious RCU usage
> [   72.214201] 5.6.0-rc1+ #5 Not tainted
> [   72.214204] -----------------------------
> [   72.214208] net/bluetooth/hci_core.c:2308 RCU-list traversed in non-reader section!!
> 
> [  333.456972] =============================
> [  333.456979] WARNING: suspicious RCU usage
> [  333.457001] 5.6.0-rc1+ #5 Not tainted
> [  333.457007] -----------------------------
> [  333.457014] net/bluetooth/hci_core.c:2318 RCU-list traversed in non-reader section!!
> 
> Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik10@...il.com>
> ---
> net/bluetooth/hci_core.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel