netdev - Re: [PATCH iproute2] xfrm: not try to delete ipcomp states when using deleteall

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADvbK_eR=s6ctXK7UwXCKddyeSDSRZx3Ok+qy_ZJ_4vxkXN9bA@mail.gmail.com>
Date:   Sat, 29 Feb 2020 12:03:57 +0800
From:   Xin Long <lucien.xin@...il.com>
To:     Stephen Hemminger <stephen@...workplumber.org>
Cc:     network dev <netdev@...r.kernel.org>,
        Steffen Klassert <steffen.klassert@...unet.com>,
        Sabrina Dubroca <sd@...asysnail.net>
Subject: Re: [PATCH iproute2] xfrm: not try to delete ipcomp states when using deleteall

On Sat, Feb 29, 2020 at 5:51 AM Stephen Hemminger
<stephen@...workplumber.org> wrote:
>
> On Mon, 24 Feb 2020 09:57:01 -0500
> Xin Long <lucien.xin@...il.com> wrote:
>
> > In kernel space, ipcomp(sub) states used by main states are not
> > allowed to be deleted by users, they would be freed only when
> > all main states are destroyed and no one uses them.
> >
> > In user space, ip xfrm sta deleteall doesn't filter these ipcomp
> > states out, and it causes errors:
> >
> >   # ip xfrm state add src 192.168.0.1 dst 192.168.0.2 spi 0x1000 \
> >       proto comp comp deflate mode tunnel sel src 192.168.0.1 dst \
> >       192.168.0.2 proto gre
> >   # ip xfrm sta deleteall
> >   Failed to send delete-all request
> >   : Operation not permitted
> >
> > This patch is to fix it by filtering ipcomp states with a check
> > xsinfo->id.proto == IPPROTO_IPIP.
> >
> > Fixes: c7699875bee0 ("Import patch ipxfrm-20040707_2.diff")
> > Signed-off-by: Xin Long <lucien.xin@...il.com>
>
>
> Wow that has been broken for a long time, does anyone use this?
I don't know, it was just found in our testcase.