netdev - Re: [PATCH v2 net-next 3/3] tcp: Prevent port hijacking when ports are exhausted.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200229183717.14616-1-kuniyu@amazon.co.jp>
Date:   Sun, 1 Mar 2020 03:37:17 +0900
From:   Kuniyuki Iwashima <kuniyu@...zon.co.jp>
To:     <edumazet@...gle.com>
CC:     <davem@...emloft.net>, <kuni1840@...il.com>, <kuniyu@...zon.co.jp>,
        <kuznet@....inr.ac.ru>, <netdev@...r.kernel.org>,
        <osa-contribution-log@...zon.com>, <yoshfuji@...ux-ipv6.org>
Subject: Re: [PATCH v2 net-next 3/3] tcp: Prevent port hijacking when ports are exhausted.

From:   Eric Dumazet <edumazet@...gle.com>
Date:   Wed, 26 Feb 2020 09:47:26 -0800
> This changelog is rather confusing, and your patch does not solve this
> precise problem.
> Patch titles are important, you are claiming something, but I fail to
> see how the patch solves the problem stated in the title.
> 
> Please be more specific, and add tests officially, in tools/testing/selftests/
> 
> 
> > If both of SO_REUSEADDR and SO_REUSEPORT are enabled, the restriction of
> > SO_REUSEPORT should be taken into account so that can only one socket be in
> > TCP_LISTEN.
> 
> Sorry, I do not understand this. If I do not understand the sentence,
> I do not read the patch
> changing one piece of code that has been very often broken in the past.
> 
> Please spend time on the changelog to give the exact outcome and goals.

I am so sorry that I wrote the changelog roughly. I appreciate for your
kind advice. I could rewrite more precise description of this issue and
respin these patches with tests.

  [PATCH v3 net-next 0/4] Improve bind(addr, 0) behaviour.
  https://lore.kernel.org/netdev/20200229113554.78338-1-kuniyu@amazon.co.jp/

Thank you so much!