netdev - Re: [patch net-next v2 08/12] flow_offload: introduce "immediate" HW stats type and allow it in mlxsw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200229193217.ejk3gbwhjcnxlk3c@salvia>
Date:   Sat, 29 Feb 2020 20:32:18 +0100
From:   Pablo Neira Ayuso <pablo@...filter.org>
To:     Jiri Pirko <jiri@...nulli.us>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, kuba@...nel.org,
        saeedm@...lanox.com, leon@...nel.org, michael.chan@...adcom.com,
        vishal@...lsio.com, jeffrey.t.kirsher@...el.com,
        idosch@...lanox.com, aelior@...vell.com, peppe.cavallaro@...com,
        alexandre.torgue@...com, jhs@...atatu.com,
        xiyou.wangcong@...il.com, ecree@...arflare.com, mlxsw@...lanox.com
Subject: Re: [patch net-next v2 08/12] flow_offload: introduce "immediate" HW
 stats type and allow it in mlxsw

On Fri, Feb 28, 2020 at 06:25:01PM +0100, Jiri Pirko wrote:
[...]
> @@ -31,7 +31,8 @@ static int mlxsw_sp_flower_parse_actions(struct mlxsw_sp *mlxsw_sp,
>  
>  	act = flow_action_first_entry_get(flow_action);
>  	switch (act->hw_stats_type) {
> -	case FLOW_ACTION_HW_STATS_TYPE_ANY:
> +	case FLOW_ACTION_HW_STATS_TYPE_ANY: /* fall-through */
> +	case FLOW_ACTION_HW_STATS_TYPE_IMMEDIATE:

This TYPE_ANY mean that driver picks the counter type for you?

Otherwise, users will not have a way to know how to interpret what
kind of counter this is.