netdev - Re: [PATCH] atm: nicstar: fix if-statement empty body warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 29 Feb 2020 21:28:55 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     rdunlap@...radead.org
Cc:     netdev@...r.kernel.org, 3chas3@...il.com,
        linux-atm-general@...ts.sourceforge.net
Subject: Re: [PATCH] atm: nicstar: fix if-statement empty body warning

From: Randy Dunlap <rdunlap@...radead.org>
Date: Thu, 27 Feb 2020 18:09:44 -0800

> From: Randy Dunlap <rdunlap@...radead.org>
> 
> When debugging via PRINTK() is not enabled, make the PRINTK()
> macro be an empty do-while block.
> 
> Thix fixes a gcc warning when -Wextra is set:
> ../drivers/atm/nicstar.c:1819:23: warning: suggest braces around empty body in an ‘else’ statement [-Wempty-body]
> 
> I have verified that there is no object code change (with gcc 7.5.0).
> 
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>

Applied, thanks Randy.