netdev - Re: [PATCH] drivers/of/of_mdio.c:fix of_mdiobus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200301165018.GN6305@lunn.ch>
Date:   Sun, 1 Mar 2020 17:50:18 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Dajun Jin <adajunjin@...il.com>
Cc:     hkallweit1@...il.com, linux@...linux.org.uk, robh+dt@...nel.org,
        frowand.list@...il.com, netdev@...r.kernel.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCH] drivers/of/of_mdio.c:fix of_mdiobus_register()

On Mon, Mar 02, 2020 at 12:41:38AM +0800, Dajun Jin wrote:
> when registers a phy_device successful, should terminate the loop
> or the phy_device would be registered in other addr.
> 
> Signed-off-by: Dajun Jin <adajunjin@...il.com>
> ---
>  drivers/of/of_mdio.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/of/of_mdio.c b/drivers/of/of_mdio.c
> index 8270bbf505fb..9f982c0627a0 100644
> --- a/drivers/of/of_mdio.c
> +++ b/drivers/of/of_mdio.c
> @@ -306,6 +306,7 @@ int of_mdiobus_register(struct mii_bus *mdio, struct device_node *np)
>  				rc = of_mdiobus_register_phy(mdio, child, addr);
>  				if (rc && rc != -ENODEV)
>  					goto unregister;
> +				break;
>  			}
>  		}
>  	}

Hi Dajun

What problem are you seeing? You explanation needs to be better.

I'm guessing you have two or more PHYs on the bus, without reg
properties?

	Andrew