netdev - Re: [PATCH net] net: phy: avoid clearing PHY interrupts twice in irq handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 01 Mar 2020 19:05:00 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     hkallweit1@...il.com
Cc:     andrew@...n.ch, f.fainelli@...il.com, linux@...linux.org.uk,
        netdev@...r.kernel.org, michael@...le.cc
Subject: Re: [PATCH net] net: phy: avoid clearing PHY interrupts twice in
 irq handler

From: Heiner Kallweit <hkallweit1@...il.com>
Date: Sun, 1 Mar 2020 21:36:09 +0100

> On all PHY drivers that implement did_interrupt() reading the interrupt
> status bits clears them. This means we may loose an interrupt that
> is triggered between calling did_interrupt() and phy_clear_interrupt().
> As part of the fix make it a requirement that did_interrupt() clears
> the interrupt.
> 
> The Fixes tag refers to the first commit where the patch applies
> cleanly.
> 
> Fixes: 49644e68f472 ("net: phy: add callback for custom interrupt handler to struct phy_driver")
> Reported-by: Michael Walle <michael@...le.cc>
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>

Applied and queued up for -stable, thanks.