netdev - Re: [RFC PATCH v2 04/22] ice: enable initial devlink support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 2 Mar 2020 17:30:56 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Jacob Keller <jacob.e.keller@...el.com>
Cc:     netdev@...r.kernel.org, valex@...lanox.com, linyunsheng@...wei.com,
        lihong.yang@...el.com, kuba@...nel.org
Subject: Re: [RFC PATCH v2 04/22] ice: enable initial devlink support

Sat, Feb 15, 2020 at 12:22:03AM CET, jacob.e.keller@...el.com wrote:

[...]

>+int ice_devlink_create_port(struct ice_pf *pf)
>+{
>+	struct devlink *devlink = priv_to_devlink(pf);
>+	struct ice_vsi *vsi = ice_get_main_vsi(pf);
>+	struct device *dev = ice_pf_to_dev(pf);
>+	int err;
>+
>+	if (!vsi) {
>+		dev_err(dev, "%s: unable to find main VSI\n", __func__);
>+		return -EIO;
>+	}
>+
>+	devlink_port_attrs_set(&pf->devlink_port, DEVLINK_PORT_FLAVOUR_PHYSICAL,
>+			       pf->hw.pf_id, false, 0, NULL, 0);
>+	err = devlink_port_register(devlink, &pf->devlink_port, pf->hw.pf_id);
>+	if (err) {
>+		dev_err(dev, "devlink_port_register failed: %d\n", err);
>+		return err;
>+	}

You need to register_netdev here. Otherwise you'll get inconsistent udev
naming.


>+	if (vsi->netdev)
>+		devlink_port_type_eth_set(&pf->devlink_port, vsi->netdev);
>+
>+	return 0;
>+}


[...]