netdev - Re: [PATCH] phylink: Improve error message when validate failed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200302163852.GH25745@shell.armlinux.org.uk>
Date:   Mon, 2 Mar 2020 16:38:52 +0000
From:   Russell King - ARM Linux admin <linux@...linux.org.uk>
To:     Hauke Mehrtens <hauke@...ke-m.de>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, andrew@...n.ch,
        f.fainelli@...il.com, hkallweit1@...il.com
Subject: Re: [PATCH] phylink: Improve error message when validate failed

On Mon, Mar 02, 2020 at 12:55:02AM +0100, Hauke Mehrtens wrote:
> This should improve the error message when the PHY validate in the MAC
> driver failed. I ran into this problem multiple times that I put wrong
> interface values into the device tree and was searching why it is
> failing with -22 (-EINVAL). This should make it easier to spot the
> problem.

Hi,

This will do as a stop-gap measure to make debugging of that easier,
but in the longer run I want MAC drivers to provide phylink with a
bitmap of the PHY_INTERFACE_MODE_*s they support.

So,

Acked-by: Russell King <rmk+kernel@...linux.org.uk>

Thanks.

> 
> Signed-off-by: Hauke Mehrtens <hauke@...ke-m.de>
> ---
>  drivers/net/phy/phylink.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
> index b4367fab7899..5347275215be 100644
> --- a/drivers/net/phy/phylink.c
> +++ b/drivers/net/phy/phylink.c
> @@ -797,8 +797,14 @@ static int phylink_bringup_phy(struct phylink *pl, struct phy_device *phy,
>  		config.interface = interface;
>  
>  	ret = phylink_validate(pl, supported, &config);
> -	if (ret)
> +	if (ret) {
> +		phylink_warn(pl, "validation of %s with support %*pb and advertisement %*pb failed: %d\n",
> +			     phy_modes(config.interface),
> +			     __ETHTOOL_LINK_MODE_MASK_NBITS, phy->supported,
> +			     __ETHTOOL_LINK_MODE_MASK_NBITS, config.advertising,
> +			     ret);
>  		return ret;
> +	}
>  
>  	phy->phylink = pl;
>  	phy->phy_link_change = phylink_phy_change;
> -- 
> 2.20.1
> 
> 

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up