netdev - Re: [RFC PATCH v2 12/22] devlink: convert snapshot id getter to return an error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200302174417.GH2168@nanopsycho>
Date:   Mon, 2 Mar 2020 18:44:17 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Jacob Keller <jacob.e.keller@...el.com>
Cc:     netdev@...r.kernel.org, valex@...lanox.com, linyunsheng@...wei.com,
        lihong.yang@...el.com, kuba@...nel.org
Subject: Re: [RFC PATCH v2 12/22] devlink: convert snapshot id getter to
 return an error

Sat, Feb 15, 2020 at 12:22:11AM CET, jacob.e.keller@...el.com wrote:
>Modify the devlink_snapshot_id_get function to return a signed value,
>enabling reporting an error on failure.
>
>This enables easily refactoring how IDs are generated and kept track of
>in the future. For now, just report ENOSPC once INT_MAX snapshot ids
>have been returned.
>
>Signed-off-by: Jacob Keller <jacob.e.keller@...el.com>

Reviewed-by: Jiri Pirko <jiri@...lanox.com>