netdev - Re: [PATCH v2 2/2] ag71xx: Call phylink_disconnect_phy() in case ag71xx_hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f5af250e-a32f-1013-92c1-a978766f984f@rempel-privat.de>
Date:   Mon, 2 Mar 2020 20:27:56 +0100
From:   Oleksij Rempel <linux@...pel-privat.de>
To:     Hauke Mehrtens <hauke@...ke-m.de>, davem@...emloft.net
Cc:     netdev@...r.kernel.org, chris.snook@...il.com, jcliburn@...il.com
Subject: Re: [PATCH v2 2/2] ag71xx: Call phylink_disconnect_phy() in case
 ag71xx_hw_enable() fails

Am 02.03.20 um 01:02 schrieb Hauke Mehrtens:
> The ag71xx_rings_cleanup() should already be handled in the
> ag71xx_hw_enable() in case it fails internally. In this function we
> should call phylink_disconnect_phy() in case the ag71xx_hw_enable()
> failed to get back into the old state.
>
> Signed-off-by: Hauke Mehrtens <hauke@...ke-m.de>
> Fixes: d51b6ce441d3 ("net: ethernet: add ag71xx driver")

Reviewed-by: Oleksij Rempel <linux@...pel-privat.de>

Thank you!

> ---
>
> v2:
>  * rebased onm top of "net: ag71xx: port to phylink"
>
>  drivers/net/ethernet/atheros/ag71xx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/atheros/ag71xx.c b/drivers/net/ethernet/atheros/ag71xx.c
> index 38683224b70b..405db37c084f 100644
> --- a/drivers/net/ethernet/atheros/ag71xx.c
> +++ b/drivers/net/ethernet/atheros/ag71xx.c
> @@ -1313,7 +1313,7 @@ static int ag71xx_open(struct net_device *ndev)
>  	return 0;
>
>  err:
> -	ag71xx_rings_cleanup(ag);
> +	phylink_disconnect_phy(ag->phylink);
>  	return ret;
>  }
>
>


--
Regards,
Oleksij