netdev - Re: [PATCH 1/5] pci: introduce pci_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e26c36b3-bdd6-2d88-8f38-f59a0c8e2b40@intel.com>
Date:   Mon, 2 Mar 2020 11:58:59 -0800
From:   Jacob Keller <jacob.e.keller@...el.com>
To:     David Miller <davem@...emloft.net>
Cc:     linux-pci@...r.kernel.org, netdev@...r.kernel.org,
        bhelgaas@...gle.com, jeffrey.t.kirsher@...el.com,
        QLogic-Storage-Upstream@...ium.com, michael.chan@...adcom.com
Subject: Re: [PATCH 1/5] pci: introduce pci_get_dsn



On 2/29/2020 9:27 PM, David Miller wrote:
> From: Jacob Keller <jacob.e.keller@...el.com>
> Date: Thu, 27 Feb 2020 14:36:31 -0800
> 
>> +int pci_get_dsn(struct pci_dev *dev, u8 dsn[])
>> +{
>> +	u32 dword;
>> +	int pos;
>> +
>> +
> 
> Just one empty line after the local variable declarations please.
> 
> Thank you.
> 

I've fixed this locally, but am going to wait to see if there is any
further feedback before sending a v2.

Thanks,
Jake