netdev - Re: [PATCH] devlink: remove trigger command from devlink-region.rst

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <76307bc8-0977-e52b-4ff8-ef0b61a6e7b6@intel.com>
Date:   Mon, 2 Mar 2020 14:22:09 -0800
From:   Jacob Keller <jacob.e.keller@...el.com>
To:     netdev@...r.kernel.org
Cc:     jiri@...nulli.us
Subject: Re: [PATCH] devlink: remove trigger command from devlink-region.rst

Heh, forgot to set subject properly, it should be [net].

Thanks,
Jake

On 3/2/2020 2:21 PM, Jacob Keller wrote:
> The devlink trigger command does not exist. While rewriting the
> documentation for devlink into the reStructuredText format,
> documentation for the trigger command was accidentally merged in. This
> occurred because the author was also working on a potential extension to
> devlink regions which included this trigger command, and accidentally
> squashed the documentation incorrectly.
> 
> Further review eventually settled on using the previously unused "new"
> command instead of creating a new trigger command.
> 
> Fix this by removing mention of the trigger command from the
> documentation.
> 
> Fixes: 0b0f945f5458 ("devlink: add a file documenting devlink regions", 2020-01-10)
> Noticed-by: Jiri Pirko <jiri@...nulli.us>
> Signed-off-by: Jacob Keller <jacob.e.keller@...el.com>
> ---
>  Documentation/networking/devlink/devlink-region.rst | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/Documentation/networking/devlink/devlink-region.rst b/Documentation/networking/devlink/devlink-region.rst
> index 1a7683e7acb2..8b46e8591fe0 100644
> --- a/Documentation/networking/devlink/devlink-region.rst
> +++ b/Documentation/networking/devlink/devlink-region.rst
> @@ -40,9 +40,6 @@ example usage
>      # Delete a snapshot using:
>      $ devlink region del pci/0000:00:05.0/cr-space snapshot 1
>  
> -    # Trigger (request) a snapshot be taken:
> -    $ devlink region trigger pci/0000:00:05.0/cr-space
> -
>      # Dump a snapshot:
>      $ devlink region dump pci/0000:00:05.0/fw-health snapshot 1
>      0000000000000000 0014 95dc 0014 9514 0035 1670 0034 db30
>