netdev - Re: [PATCH 2/5] bnxt_en: use pci_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200302222541.GA171636@google.com>
Date:   Mon, 2 Mar 2020 16:25:41 -0600
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Jacob Keller <jacob.e.keller@...el.com>
Cc:     linux-pci@...r.kernel.org, netdev@...r.kernel.org,
        Michael Chan <michael.chan@...adcom.com>
Subject: Re: [PATCH 2/5] bnxt_en: use pci_get_dsn

On Thu, Feb 27, 2020 at 02:36:32PM -0800, Jacob Keller wrote:
> Replace the open-coded implementation for reading the PCIe DSN with
> pci_get_dsn.
> 
> Signed-off-by: Jacob Keller <jacob.e.keller@...el.com>
> Cc: Michael Chan <michael.chan@...adcom.com>
> ---
>  drivers/net/ethernet/broadcom/bnxt/bnxt.c | 14 ++++----------
>  1 file changed, 4 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> index 597e6fd5bfea..55f078fc067e 100644
> --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> @@ -11755,20 +11755,14 @@ static int bnxt_init_mac_addr(struct bnxt *bp)
>  static int bnxt_pcie_dsn_get(struct bnxt *bp, u8 dsn[])
>  {
>  	struct pci_dev *pdev = bp->pdev;
> -	int pos = pci_find_ext_capability(pdev, PCI_EXT_CAP_ID_DSN);
> -	u32 dw;
> +	int err;
>  
> -	if (!pos) {
> +	err = pci_get_dsn(pdev, dsn);
> +	if (err) {
>  		netdev_info(bp->dev, "Unable do read adapter's DSN");

"Unable *to* read..."

Not your fault, I guess :)

> -		return -EOPNOTSUPP;
> +		return err;
>  	}
>  
> -	/* DSN (two dw) is at an offset of 4 from the cap pos */
> -	pos += 4;
> -	pci_read_config_dword(pdev, pos, &dw);
> -	put_unaligned_le32(dw, &dsn[0]);
> -	pci_read_config_dword(pdev, pos + 4, &dw);
> -	put_unaligned_le32(dw, &dsn[4]);
>  	bp->flags |= BNXT_FLAG_DSN_VALID;
>  	return 0;
>  }
> -- 
> 2.25.0.368.g28a2d05eebfb
>