netdev - Re: [PATCH 3/7] octeontx2-pf: Support to enable/disable pause frames via ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200302130155.GE31977@lunn.ch>
Date:   Mon, 2 Mar 2020 14:01:55 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     sunil.kovvuri@...il.com
Cc:     netdev@...r.kernel.org, davem@...emloft.net,
        Geetha sowjanya <gakula@...vell.com>,
        Sunil Goutham <sgoutham@...vell.com>
Subject: Re: [PATCH 3/7] octeontx2-pf: Support to enable/disable pause frames
 via ethtool

Hi Sunil

> +static int otx2_set_pauseparam(struct net_device *netdev,
> +			       struct ethtool_pauseparam *pause)
> +{
> +	struct otx2_nic *pfvf = netdev_priv(netdev);
> +
> +	if (pause->autoneg)
> +		return -EOPNOTSUPP;

Nice to see somebody getting that bit correct.

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew