[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 2 Mar 2020 17:03:12 -0800
From: Alexei Starovoitov <alexei.starovoitov@...il.com>
To: Toke Høiland-Jørgensen <toke@...hat.com>
Cc: daniel@...earbox.net, ast@...com, bpf@...r.kernel.org,
netdev@...r.kernel.org, Andrey Ignatov <rdna@...com>
Subject: Re: [PATCH bpf] selftests/bpf: Declare bpf_log_buf variables as
static
On Mon, Mar 02, 2020 at 03:53:48PM +0100, Toke Høiland-Jørgensen wrote:
> The cgroup selftests did not declare the bpf_log_buf variable as static, leading
> to a linker error with GCC 10 (which defaults to -fno-common). Fix this by
> adding the missing static declarations.
>
> Fixes: 257c88559f36 ("selftests/bpf: Convert test_cgroup_attach to prog_tests")
> Signed-off-by: Toke Høiland-Jørgensen <toke@...hat.com>
Applied to bpf-next.
It's hardly a fix. Fixes tag doesn't make it a fix in my mind.
I really see no point rushing it into bpf->net->Linus's tree at this point.
Powered by blists - more mailing lists