lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 3 Mar 2020 15:09:12 +0100 From: Andrew Lunn <andrew@...n.ch> To: Oleksij Rempel <o.rempel@...gutronix.de> Cc: Christian Herber <christian.herber@....com>, Heiner Kallweit <hkallweit1@...il.com>, Florian Fainelli <f.fainelli@...il.com>, Marek Vasut <marex@...x.de>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Pengutronix Kernel Team <kernel@...gutronix.de>, David Jander <david@...tonic.nl>, "David S. Miller" <davem@...emloft.net> Subject: Re: [PATCH v1] net: phy: tja11xx: add TJA1102 support > > Hi Oleksij, Heiner, Marc, > > > > You could also refer the solution implemented here as part of a TJA110x driver: > > https://source.codeaurora.org/external/autoivnsw/tja110x_linux_phydev/about/ > > OK, thank you! > > Suddenly, the solution in this driver is not mainlainable. It may match on > ther PHYs with PHYID == 0. > > See this part of the code: > #define NXP_PHY_ID_TJA1102P1 (0x00000000U) > ... > , { > .phy_id = NXP_PHY_ID_TJA1102P1, > .name = "TJA1102_p1", > .phy_id_mask = NXP_PHY_ID_MASK, Noooo You cannot assume NXP is the only silicon vendor to manufacture broken silicon with a PHY ID of 0. Andrew
Powered by blists - more mailing lists