netdev - Re: [PATCH] iwlwifi: pcie: restore support for Killer Qu C0 NICs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue,  3 Mar 2020 15:29:25 +0000 (UTC)
From:   Kalle Valo <kvalo@...eaurora.org>
To:     "Jan Alexander Steffens (heftig)" <jan.steffens@...il.com>
Cc:     Johannes Berg <johannes.berg@...el.com>,
        Emmanuel Grumbach <emmanuel.grumbach@...el.com>,
        Luca Coelho <luciano.coelho@...el.com>,
        Intel Linux Wireless <linuxwifi@...el.com>,
        "David S. Miller" <davem@...emloft.net>,
        "Jan Alexander Steffens (heftig)" <jan.steffens@...il.com>,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iwlwifi: pcie: restore support for Killer Qu C0 NICs

"Jan Alexander Steffens (heftig)" <jan.steffens@...il.com> wrote:

> Commit 809805a820c6 ("iwlwifi: pcie: move some cfg mangling from
> trans_pcie_alloc to probe") refactored the cfg mangling. Unfortunately,
> in this process the lines which picked the right cfg for Killer Qu C0
> NICs after C0 detection were lost. These lines were added by commit
> b9500577d361 ("iwlwifi: pcie: handle switching killer Qu B0 NICs to
> C0").
> 
> I suspect this is more of the "merge damage" which commit 7cded5658329
> ("iwlwifi: pcie: fix merge damage on making QnJ exclusive") talks about.
> 
> Restore the missing lines so the driver loads the right firmware for
> these NICs.
> 
> Fixes: 809805a820c6 ("iwlwifi: pcie: move some cfg mangling from trans_pcie_alloc to probe")
> Signed-off-by: Jan Alexander Steffens (heftig) <jan.steffens@...il.com>

As Luca said, this fails to apply to wireless-drivers. Please rebase and
resend as v2.

Recorded preimage for 'drivers/net/wireless/intel/iwlwifi/pcie/drv.c'
error: Failed to merge in the changes.
Applying: iwlwifi: pcie: restore support for Killer Qu C0 NICs
Using index info to reconstruct a base tree...
M	drivers/net/wireless/intel/iwlwifi/pcie/drv.c
Falling back to patching base and 3-way merge...
Auto-merging drivers/net/wireless/intel/iwlwifi/pcie/drv.c
CONFLICT (content): Merge conflict in drivers/net/wireless/intel/iwlwifi/pcie/drv.c
Patch failed at 0001 iwlwifi: pcie: restore support for Killer Qu C0 NICs
The copy of the patch that failed is found in: .git/rebase-apply/patch

Patch set to Changes Requested.

-- 
https://patchwork.kernel.org/patch/11309095/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches