[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 3 Mar 2020 16:39:55 +0100
From: Stefan Schmidt <stefan@...enfreihafen.org>
To: Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net
Cc: netdev@...r.kernel.org, Alexander Aring <alex.aring@...il.com>,
alex.bluesman.smirnov@...il.com, linux-wpan@...r.kernel.org
Subject: Re: [PATCH net 05/16] nl802154: add missing attribute validation for
dev_type
Hello.
On 03.03.20 06:05, Jakub Kicinski wrote:
> Add missing attribute type validation for IEEE802154_ATTR_DEV_TYPE
> to the netlink policy.
>
> Fixes: 90c049b2c6ae ("ieee802154: interface type to be added")
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
> CC: Alexander Aring <alex.aring@...il.com>
> CC: Stefan Schmidt <stefan@...enfreihafen.org>
> CC: alex.bluesman.smirnov@...il.com
> CC: linux-wpan@...r.kernel.org
> ---
> net/ieee802154/nl_policy.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/ieee802154/nl_policy.c b/net/ieee802154/nl_policy.c
> index 824e7e84014c..0672b2f01586 100644
> --- a/net/ieee802154/nl_policy.c
> +++ b/net/ieee802154/nl_policy.c
> @@ -27,6 +27,7 @@ const struct nla_policy ieee802154_policy[IEEE802154_ATTR_MAX + 1] = {
> [IEEE802154_ATTR_BAT_EXT] = { .type = NLA_U8, },
> [IEEE802154_ATTR_COORD_REALIGN] = { .type = NLA_U8, },
> [IEEE802154_ATTR_PAGE] = { .type = NLA_U8, },
> + [IEEE802154_ATTR_DEV_TYPE] = { .type = NLA_U8, },
> [IEEE802154_ATTR_COORD_SHORT_ADDR] = { .type = NLA_U16, },
> [IEEE802154_ATTR_COORD_HW_ADDR] = { .type = NLA_HW_ADDR, },
> [IEEE802154_ATTR_COORD_PAN_ID] = { .type = NLA_U16, },
>
The reason to split this off from the patch before is to have the Fixes
tag differently to point to its origin?
Might be a bit to much work for this little subsystem, but you did it
already, so:
Acked-by: Stefan Schmidt <stefan@...enfreihafen.org>
regards
Stefan Schmidt
Powered by blists - more mailing lists