netdev - Re: [PATCH net 06/16] can: add missing attribute validation for termination

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 3 Mar 2020 20:58:30 +0100
From:   Oliver Hartkopp <socketcan@...tkopp.net>
To:     Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net
Cc:     netdev@...r.kernel.org, Wolfgang Grandegger <wg@...ndegger.com>,
        Marc Kleine-Budde <mkl@...gutronix.de>,
        linux-can@...r.kernel.org
Subject: Re: [PATCH net 06/16] can: add missing attribute validation for
 termination



On 03/03/2020 06.05, Jakub Kicinski wrote:
> Add missing attribute validation for IFLA_CAN_TERMINATION
> to the netlink policy.
> 
> Fixes: 12a6075cabc0 ("can: dev: add CAN interface termination API")
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
> CC: Wolfgang Grandegger <wg@...ndegger.com>
> CC: Marc Kleine-Budde <mkl@...gutronix.de>
> CC: Oliver Hartkopp <socketcan@...tkopp.net>
> CC: linux-can@...r.kernel.org
> ---
>   drivers/net/can/dev.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/can/dev.c b/drivers/net/can/dev.c
> index 6ee06a49fb4c..68834a2853c9 100644
> --- a/drivers/net/can/dev.c
> +++ b/drivers/net/can/dev.c
> @@ -883,6 +883,7 @@ static const struct nla_policy can_policy[IFLA_CAN_MAX + 1] = {
>   				= { .len = sizeof(struct can_bittiming) },
>   	[IFLA_CAN_DATA_BITTIMING_CONST]
>   				= { .len = sizeof(struct can_bittiming_const) },
> +	[IFLA_CAN_TERMINATION]	= { .type = NLA_U16 },
>   };
>   
>   static int can_validate(struct nlattr *tb[], struct nlattr *data[],

Acked-by: Oliver Hartkopp <socketcan@...tkopp.net>

Thanks Jakub for catching all these missing defs!

Best regards,
Oliver