netdev - RE: [PATCH net 1/1] e1000e: Stop tx/rx setup spinning for upwards of 300us.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ee1f7e3e088e49478734d46dfcb8deb8@AcuMS.aculab.com>
Date:   Wed, 4 Mar 2020 09:44:08 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'David Miller' <davem@...emloft.net>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "bruce.w.allan@...el.com" <bruce.w.allan@...el.com>,
        "jeffrey.e.pieper@...el.com" <jeffrey.e.pieper@...el.com>,
        "jeffrey.t.kirsher@...el.com" <jeffrey.t.kirsher@...el.com>
Subject: RE: [PATCH net 1/1] e1000e: Stop tx/rx setup spinning for upwards of
 300us.

From: David Miller
> Sent: 04 March 2020 00:02
> 
> I'll let the Intel folks review and integrate this as it's a
> non-trivial change honestly.

Unfortunately I don't think anyone else properly reviewed the
original patch.

I suspect the real fix is to do a readback and rewrite.
(Assuming the hardware is ignoring the writes.)

For the 'interrupt enable' write, possibly get a reschedule
of the poll function by pretending there is more in the rx ring.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)