netdev - Re: [PATCH net-next 1/2] net/sched: act_ct: Fix ipv6 lookup of offloaded connections

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200304140648.GB4558@nanopsycho>
Date:   Wed, 4 Mar 2020 15:06:48 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Paul Blakey <paulb@...lanox.com>
Cc:     Saeed Mahameed <saeedm@...lanox.com>,
        Oz Shlomo <ozsh@...lanox.com>,
        Jakub Kicinski <jakub.kicinski@...ronome.com>,
        Vlad Buslov <vladbu@...lanox.com>,
        David Miller <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Jiri Pirko <jiri@...lanox.com>, Roi Dayan <roid@...lanox.com>,
        Cong Wang <xiyou.wangcong@...il.com>,
        Jamal Hadi Salim <jhs@...atatu.com>
Subject: Re: [PATCH net-next 1/2] net/sched: act_ct: Fix ipv6 lookup of
 offloaded connections

Wed, Mar 04, 2020 at 12:49:38PM CET, paulb@...lanox.com wrote:
>When checking the protocol number tcf_ct_flow_table_lookup() handles
>the flow as if it's always ipv4, while it can be ipv6.
>
>Instead, refactor the code to fetch the tcp header, if available,
>in the relevant family (ipv4/ipv6) filler function, and do the
>check on the returned tcp header.
>
>Fixes: 46475bb20f4b ("net/sched: act_ct: Software offload of established flows")
>Signed-off-by: Paul Blakey <paulb@...lanox.com>

Reviewed-by: Jiri Pirko <jiri@...lanox.com>