netdev - Re: [PATCH net] ionic: fix vf op lock usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3d69152f-2a5c-b578-f5af-12dc057ee3a0@pensando.io>
Date:   Wed, 4 Mar 2020 09:38:02 -0800
From:   Shannon Nelson <snelson@...sando.io>
To:     Parav Pandit <parav@...lanox.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net] ionic: fix vf op lock usage

On 3/4/20 9:31 AM, Parav Pandit wrote:
>> Sent: Wednesday, March 4, 2020 11:22 AM
>> To: davem@...emloft.net; netdev@...r.kernel.org
>> These are a couple of read locks that should be write locks.
>>
>> Fixes: commit fbb39807e9ae ("ionic: support sr-iov operations")
> It should be,
>
> Fixes: fbb39807e9ae ("ionic: support sr-iov operations")

Thanks, I'll fix that.
sln

>
>> Signed-off-by: Shannon Nelson <snelson@...sando.io>
>> ---
>>   drivers/net/ethernet/pensando/ionic/ionic_lif.c | 8 ++++----
>>   1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/pensando/ionic/ionic_lif.c
>> b/drivers/net/ethernet/pensando/ionic/ionic_lif.c
>> index 191271f6260d..c2f5b691e0fa 100644
>> --- a/drivers/net/ethernet/pensando/ionic/ionic_lif.c
>> +++ b/drivers/net/ethernet/pensando/ionic/ionic_lif.c
>> @@ -1688,7 +1688,7 @@ static int ionic_set_vf_mac(struct net_device
>> *netdev, int vf, u8 *mac)
>>   	if (!(is_zero_ether_addr(mac) || is_valid_ether_addr(mac)))
>>   		return -EINVAL;
>>
>> -	down_read(&ionic->vf_op_lock);
>> +	down_write(&ionic->vf_op_lock);
>>
>>   	if (vf >= pci_num_vf(ionic->pdev) || !ionic->vfs) {
>>   		ret = -EINVAL;
>> @@ -1698,7 +1698,7 @@ static int ionic_set_vf_mac(struct net_device
>> *netdev, int vf, u8 *mac)
>>   			ether_addr_copy(ionic->vfs[vf].macaddr, mac);
>>   	}
>>
>> -	up_read(&ionic->vf_op_lock);
>> +	up_write(&ionic->vf_op_lock);
>>   	return ret;
>>   }
>>
>> @@ -1719,7 +1719,7 @@ static int ionic_set_vf_vlan(struct net_device
>> *netdev, int vf, u16 vlan,
>>   	if (proto != htons(ETH_P_8021Q))
>>   		return -EPROTONOSUPPORT;
>>
>> -	down_read(&ionic->vf_op_lock);
>> +	down_write(&ionic->vf_op_lock);
>>
>>   	if (vf >= pci_num_vf(ionic->pdev) || !ionic->vfs) {
>>   		ret = -EINVAL;
>> @@ -1730,7 +1730,7 @@ static int ionic_set_vf_vlan(struct net_device
>> *netdev, int vf, u16 vlan,
>>   			ionic->vfs[vf].vlanid = vlan;
>>   	}
>>
>> -	up_read(&ionic->vf_op_lock);
>> +	up_write(&ionic->vf_op_lock);
>>   	return ret;
>>   }
>>
>> --
>> 2.17.1
> I missed to review this after Christmas break.
>
> Reviewed-by: Parav Pandit <parav@...lanox.com>
>