netdev - Re: [PATCH net-next v2 08/12] ice: let core reject the unsupported coalescing parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <554e1a91bd0d4256720060d513f6d0fdd1d1c884.camel@intel.com>
Date:   Wed, 04 Mar 2020 10:08:10 -0800
From:   Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:     Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net
Cc:     mkubecek@...e.cz, thomas.lendacky@....com, benve@...co.com,
        _govind@....com, pkaustub@...co.com, peppe.cavallaro@...com,
        alexandre.torgue@...com, joabreu@...opsys.com, snelson@...sando.io,
        yisen.zhuang@...wei.com, salil.mehta@...wei.com,
        jacob.e.keller@...el.com, alexander.h.duyck@...ux.intel.com,
        michael.chan@...adcom.com, saeedm@...lanox.com, leon@...nel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2 08/12] ice: let core reject the unsupported
 coalescing parameters

On Tue, 2020-03-03 at 20:33 -0800, Jakub Kicinski wrote:
> Set ethtool_ops->coalesce_types to let the core reject
> unsupported coalescing parameters.
> 
> This driver correctly rejects all unsupported parameters.
> As a side effect of these changes the info message about
> the bad parameter will no longer be printed. We also
> always reject the tx_coalesce_usecs_high param, even
> if the target queue pair does not have a TX queue.
> 
> v2: allow adaptive TX
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Acked-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>

> ---
>  drivers/net/ethernet/intel/ice/ice_ethtool.c | 59 +-----------------
> --
>  1 file changed, 3 insertions(+), 56 deletions(-)


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)