netdev - Re: [PATCH net-next v2 01/12] ethtool: add infrastructure for centralized checking of coalescing parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <410f35ef-b023-1c24-f7e7-2724bae121ff@solarflare.com>
Date:   Wed, 4 Mar 2020 18:16:13 +0000
From:   Edward Cree <ecree@...arflare.com>
To:     Alexander Duyck <alexander.h.duyck@...ux.intel.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Michal Kubecek <mkubecek@...e.cz>
CC:     <davem@...emloft.net>, <thomas.lendacky@....com>,
        <benve@...co.com>, <_govind@....com>, <pkaustub@...co.com>,
        <peppe.cavallaro@...com>, <alexandre.torgue@...com>,
        <joabreu@...opsys.com>, <snelson@...sando.io>,
        <yisen.zhuang@...wei.com>, <salil.mehta@...wei.com>,
        <jeffrey.t.kirsher@...el.com>, <jacob.e.keller@...el.com>,
        <michael.chan@...adcom.com>, <saeedm@...lanox.com>,
        <leon@...nel.org>, <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next v2 01/12] ethtool: add infrastructure for
 centralized checking of coalescing parameters

On 04/03/2020 18:12, Alexander Duyck wrote:
> So one thing I just wanted to point out. The used_types won't necessarily
> be correct because it is only actually checking for non-zero types. There
> are some of these values where a zero is a valid input
Presumably in the netlink ethtool world we'll want to instead check if
 the attribute was passed?  Not sure but that might affect what semantics
 we want to imply now.