netdev - Re: [PATCH for-rc] RDMA/siw: Fix passive connection establishment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200304182411.GA1201@ziepe.ca>
Date:   Wed, 4 Mar 2020 14:24:11 -0400
From:   Jason Gunthorpe <jgg@...pe.ca>
To:     Bernard Metzler <bmt@...ich.ibm.com>
Cc:     chuck.lever@...cle.com, dledford@...hat.com, leon@...nel.org,
        linux-kernel@...r.kernel.org, linux-rdma@...r.kernel.org,
        netdev@...r.kernel.org, parav@...lanox.com,
        syzkaller-bugs@...glegroups.com, willy@...radead.org
Subject: Re: [PATCH for-rc] RDMA/siw: Fix passive connection establishment

On Fri, Feb 28, 2020 at 06:35:34PM +0100, Bernard Metzler wrote:
> Holding the rtnl_lock while iterating a devices interface
> address list potentially causes deadlocks with the
> cma_netdev_callback. While this was implemented to
> limit the scope of a wildcard listen to addresses
> of the current device only, a better solution limits
> the scope of the socket to the device. This completely
> avoiding locking, and also results in significant code
> simplification.
> 
> Reported-by: syzbot+55de90ab5f44172b0c90@...kaller.appspotmail.com
> Suggested-by: Jason Gunthorpe <jgg@...pe.ca>
> Signed-off-by: Bernard Metzler <bmt@...ich.ibm.com>
> ---
>  drivers/infiniband/sw/siw/siw_cm.c | 137 +++++++----------------------
>  1 file changed, 31 insertions(+), 106 deletions(-)

Applied to for-next, the possibility of hitting the locking inversion
found by syzkaller is really remote as you'd have to run siw on top of
bond and then do horrible things to the bond.

Jason