netdev - Re: [PATCH net-next 3/4] pie: remove pie_vars->accu_prob

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200303.174305.187736433958803345.davem@davemloft.net>
Date:   Tue, 03 Mar 2020 17:43:05 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     lesliemonis@...il.com
Cc:     netdev@...r.kernel.org, tahiliani@...k.edu.in, gautamramk@...il.com
Subject: Re: [PATCH net-next 3/4] pie: remove pie_vars->accu_prob_overflows

From: Leslie Monis <lesliemonis@...il.com>
Date: Mon,  2 Mar 2020 20:48:30 +0530

> -	prandom_bytes(&rnd, 8);
> +	prandom_bytes(&rnd, 7);

This is undefined because it depends upon the endianness whether you
are initializing the more significant 7 bytes or the least significant
7 bytes of rnd.

I think you should just keep this at 8 and explicitly clear out the
top byte.