netdev - Re: [PATCH net-next v2 0/4] pie: minor improvements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200304.132611.1082983925572874313.davem@davemloft.net>
Date:   Wed, 04 Mar 2020 13:26:11 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     kuba@...nel.org
Cc:     lesliemonis@...il.com, netdev@...r.kernel.org,
        tahiliani@...k.edu.in, gautamramk@...il.com
Subject: Re: [PATCH net-next v2 0/4] pie: minor improvements

From: Jakub Kicinski <kuba@...nel.org>
Date: Wed, 4 Mar 2020 12:49:17 -0800

> On Thu,  5 Mar 2020 00:25:58 +0530 Leslie Monis wrote:
>> This patch series includes the following minor changes with
>> respect to the PIE/FQ-PIE qdiscs:
>> 
>>  - Patch 1 removes some ambiguity by using the term "backlog"
>>            instead of "qlen" when referring to the queue length
>>            in bytes.
>>  - Patch 2 removes redundant type casting on two expressions.
>>  - Patch 3 removes the pie_vars->accu_prob_overflows variable
>>            without affecting the precision in calculations and
>>            makes the size of the pie_vars structure exactly 64
>>            bytes.
>>  - Patch 4 realigns a comment affected by a change in patch 3.
>> 
>> Changes from v1 to v2:
>>  - Kept 8 as the argument to prandom_bytes() instead of changing it
>>    to 7 as suggested by David Miller.
> 
> I was wondering if patch 3 changes make user-visible changes but it
> seems those should be only slight accuracy adjustments, so LGTM. FWIW:
> 
> Reviewed-by: Jakub Kicinski <kuba@...nel.org>

Series applied, thanks everyone.