lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 05 Mar 2020 13:32:04 +0100
From:   Jakub Sitnicki <>
To:     Lorenz Bauer <>
Cc:, Alexei Starovoitov <>,
        Daniel Borkmann <>,
        Eric Dumazet <>,
        "David S. Miller" <>,
        Jakub Kicinski <>,
        Alexey Kuznetsov <>,
        Hideaki YOSHIFUJI <>,,,,
Subject: Re: [PATCH bpf-next v3 05/12] bpf: sockmap: move generic sockmap hooks from BPF TCP

On Wed, Mar 04, 2020 at 11:13 AM CET, Lorenz Bauer wrote:
> The init, close and unhash handlers from TCP sockmap are generic,
> and can be reused by UDP sockmap. Move the helpers into the sockmap code
> base and expose them. This requires tcp_bpf_get_proto and tcp_bpf_clone to
> be conditional on BPF_STREAM_PARSER.
> The moved functions are unmodified, except that sk_psock_unlink is
> renamed to sock_map_unlink to better match its behaviour.
> Signed-off-by: Lorenz Bauer <>
> ---

To spell out the tcp_bpf_get_proto() and tcp_bpf_clone() dependency on
CONFIG_BPF_STREAM_PARSER - both of these functions access tcp_bpf_prots,
which now hold pointers to sock_map_{unhash,close}. And
sock_map_{unhash,close} get built when CONFIG_BPF_STREAM_PARSER is

Reviewed-by: Jakub Sitnicki <>


Powered by blists - more mailing lists