netdev - Re: [PATCH net-next v2] xen-netfront: add basic XDP support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200305150347.740b209f@carbon>
Date:   Thu, 5 Mar 2020 15:04:00 +0100
From:   Jesper Dangaard Brouer <brouer@...hat.com>
To:     Denis Kirjanov <kda@...ux-powerpc.org>
Cc:     brouer@...hat.com, netdev@...r.kernel.org, jgross@...e.com,
        ilias.apalodimas@...aro.org
Subject: Re: [PATCH net-next v2] xen-netfront: add basic XDP support

On Mon,  2 Mar 2020 17:21:14 +0300
Denis Kirjanov <kda@...ux-powerpc.org> wrote:

> diff --git a/drivers/net/xen-netback/xenbus.c b/drivers/net/xen-netback/xenbus.c
> index 286054b..81a6023 100644
> --- a/drivers/net/xen-netback/xenbus.c
> +++ b/drivers/net/xen-netback/xenbus.c
> @@ -393,6 +393,20 @@ static void set_backend_state(struct backend_info *be,
>  	}
>  }
>  
> +static void read_xenbus_fronetend_xdp(struct backend_info *be,
> +				      struct xenbus_device *dev)

Strange spelling of this function name: 'fronetend'

> +{
> +	struct xenvif *vif = be->vif;
> +	unsigned int val;
> +	int err;
> +
> +	err = xenbus_scanf(XBT_NIL, dev->otherend,
> +			   "feature-xdp", "%u", &val);
> +	if (err < 0)
> +		return;
> +	vif->xdp_enabled = val;
> +}
> +
>  /**
>   * Callback received when the frontend's state changes.
>   */
> @@ -417,6 +431,11 @@ static void frontend_changed(struct xenbus_device *dev,
>  		set_backend_state(be, XenbusStateConnected);
>  		break;
>  
> +	case XenbusStateReconfiguring:
> +		read_xenbus_fronetend_xdp(be, dev);
                            ^^^^^^^^
> +		xenbus_switch_state(dev, XenbusStateReconfigured);
> +		break;
> +

-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer