netdev - Re: [PATCH v2 net-next 2/8] ionic: remove pragma packed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 4 Mar 2020 16:05:21 -0800
From:   Shannon Nelson <snelson@...sando.io>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH v2 net-next 2/8] ionic: remove pragma packed

On 3/4/20 11:54 AM, Jakub Kicinski wrote:
> On Tue,  3 Mar 2020 20:20:07 -0800 Shannon Nelson wrote:
>> Replace the misguided "#pragma packed" with tags on each
>> struct/union definition that actually needs it.  This is safer
>> and more efficient on the various compilers and architectures.
>>
>> Signed-off-by: Shannon Nelson <snelson@...sando.io>
> Ah, I think I missed this pragma in original review :S
>
> nit: I think __packed is preferred

I was hoping to keep with the __attribute__((packed)) format, as I found 
in other kernel headers, as this file is shared in places that don't 
understand the __packed shorthand.  However, with Dave's added urging, 
I'll fix that in v3.

sln