netdev - Re: [PATCH net-next v2 0/3] net: rmnet: several code cleanup for rmnet module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200304185347.797972fb@kicinski-fedora-PC1C0HJN>
Date:   Wed, 4 Mar 2020 18:53:47 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     subashab@...eaurora.org
Cc:     Taehee Yoo <ap420073@...il.com>, davem@...emloft.net,
        stranche@...eaurora.org, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2 0/3] net: rmnet: several code cleanup for
 rmnet module

On Wed, 04 Mar 2020 16:43:58 -0700 subashab@...eaurora.org wrote:
> On 2020-03-04 16:24, Taehee Yoo wrote:
> > This patchset is to cleanup rmnet module code.
> > 
> > 1. The first patch is to add module alias
> > rmnet module can not be loaded automatically because there is no
> > alias name.
> > 
> > 2. The second patch is to add extack error message code.
> > When rmnet netlink command fails, it doesn't print any error message.
> > So, users couldn't know the exact reason.
> > In order to tell the exact reason to the user, the extack error message
> > is used in this patch.
> > 
> > 3. The third patch is to use GFP_KERNEL instead of GFP_ATOMIC.
> > In the sleepable context, GFP_KERNEL can be used.
> > So, in this patch, GFP_KERNEL is used instead of GFP_ATOMIC.
> > 
> > Change log:
> >  - v1->v2: change error message in the second patch.
>
> For the series:
> 
> Acked-by: Subash Abhinov Kasiviswanathan <subashab@...eaurora.org>

LGTM as well, thanks!