netdev - Re: [PATCH net-next] hsr: fix refcnt leak of hsr slave interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200305.120042.583751283879909582.davem@davemloft.net>
Date:   Thu, 05 Mar 2020 12:00:42 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     ap420073@...il.com
Cc:     kuba@...nel.org, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] hsr: fix refcnt leak of hsr slave interface

From: Taehee Yoo <ap420073@...il.com>
Date: Thu,  5 Mar 2020 00:02:54 +0000

> In the commit e0a4b99773d3 ("hsr: use upper/lower device infrastructure"),
> dev_get() was removed but dev_put() in the error path wasn't removed.
> So, if creating hsr interface command is failed, the reference counter leak
> of lower interface would occur.
> 
> Test commands:
>     ip link add dummy0 type dummy
>     ip link add ipvlan0 link dummy0 type ipvlan mode l2
>     ip link add ipvlan1 link dummy0 type ipvlan mode l2
>     ip link add hsr0 type hsr slave1 ipvlan0 slave2 ipvlan1
>     ip link del ipvlan0
> 
> Result:
> [  633.271992][ T1280] unregister_netdevice: waiting for ipvlan0 to become free. Usage count = -1
> 
> Fixes: e0a4b99773d3 ("hsr: use upper/lower device infrastructure")
> Signed-off-by: Taehee Yoo <ap420073@...il.com>

Applied.