netdev - Re: [PATCH] sfc: complete the next packet when we receive a timestamp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 05 Mar 2020 14:57:13 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     tzhao@...arflare.com
Cc:     linux-net-drivers@...arflare.com, netdev@...r.kernel.org
Subject: Re: [PATCH] sfc: complete the next packet when we receive a
 timestamp

From: Tom Zhao <tzhao@...arflare.com>
Date: Thu, 5 Mar 2020 11:38:45 +0000

> We now ignore the "completion" event when using tx queue timestamping,
> and only pay attention to the two (high and low) timestamp events. The
> NIC will send a pair of timestamp events for every packet transmitted.
> The current firmware may merge the completion events, and it is possible
> that future versions may reorder the completion and timestamp events.
> As such the completion event is not useful.
> 
> Without this patch in place a merged completion event on a queue with
> timestamping will cause a "spurious TX completion" error. This affects
> SFN8000-series adapters.
> 
> Signed-off-by: Tom Zhao <tzhao@...arflare.com>

Applied, thank you.