lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 5 Mar 2020 12:02:55 +0530
From:   Yadu Kishore <kyk.segfault@...il.com>
To:     David Laight <David.Laight@...lab.com>,
        Willem de Bruijn <willemdebruijn.kernel@...il.com>,
        David Miller <davem@...emloft.net>
Cc:     Network Development <netdev@...r.kernel.org>
Subject: Re: [PATCH v2] net: Make skb_segment not to compute checksum if
 network controller supports checksumming

Hi all,

Though there is scope to optimise the checksum code (from C to asm) for such
architectures, it is not the intent of this patchset.
The intent here is only to enable offloading checksum during GSO.

The perf data I presented shows that ~7.4% of the CPU is spent doing checksum
in the GSO path for architectures where the checksum code is not implemented in
assembly (arm64).
If the network controller hardware supports checksumming, then I feel
that it is worthwhile to offload this even during GSO for such architectures
and save the 7.25% of the host cpu cycles.

Thanks,
Yadu Kishore

Powered by blists - more mailing lists