netdev - Re: [PATCH net-next v3 10/12] mlx5: reject unsupported coalescing params

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 5 Mar 2020 08:14:33 +0000
From:   Saeed Mahameed <saeedm@...lanox.com>
To:     "kuba@...nel.org" <kuba@...nel.org>,
        "davem@...emloft.net" <davem@...emloft.net>
CC:     "andrew@...n.ch" <andrew@...n.ch>,
        "michael.chan@...adcom.com" <michael.chan@...adcom.com>,
        "benve@...co.com" <benve@...co.com>,
        "peppe.cavallaro@...com" <peppe.cavallaro@...com>,
        "_govind@....com" <_govind@....com>,
        "jeffrey.t.kirsher@...el.com" <jeffrey.t.kirsher@...el.com>,
        "thomas.lendacky@....com" <thomas.lendacky@....com>,
        "leon@...nel.org" <leon@...nel.org>,
        "ecree@...arflare.com" <ecree@...arflare.com>,
        "joabreu@...opsys.com" <joabreu@...opsys.com>,
        "snelson@...sando.io" <snelson@...sando.io>,
        "mkubecek@...e.cz" <mkubecek@...e.cz>,
        "alexander.h.duyck@...ux.intel.com" 
        <alexander.h.duyck@...ux.intel.com>,
        "yisen.zhuang@...wei.com" <yisen.zhuang@...wei.com>,
        "salil.mehta@...wei.com" <salil.mehta@...wei.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "alexandre.torgue@...com" <alexandre.torgue@...com>,
        "jacob.e.keller@...el.com" <jacob.e.keller@...el.com>
Subject: Re: [PATCH net-next v3 10/12] mlx5: reject unsupported coalescing
 params

On Wed, 2020-03-04 at 21:15 -0800, Jakub Kicinski wrote:
> Set ethtool_ops->supported_coalesce_params to let
> the core reject unsupported coalescing parameters.
> 
> This driver did not previously reject unsupported parameters.
> 
> v3: adjust commit message for new member name
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
>  drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c    | 3 +++
>  drivers/net/ethernet/mellanox/mlx5/core/en_rep.c        | 6 ++++++
>  drivers/net/ethernet/mellanox/mlx5/core/ipoib/ethtool.c | 3 +++
>  3 files changed, 12 insertions(+)
> 

the only minor thing is the duplication of the same flags in all types
of mlx5 netdevs, all mlx5 netdevs use the same infrastructure of rx/tx
ring management, so they will always share the same flags. 

Anyway i can follow up with a patch to factor out the duplication.

Acked-by: Saeed Mahameed <saeedm@...lanox.com>

> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c
> b/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c
> index 06f6f08ff5eb..01539b874b5e 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c
> @@ -1965,6 +1965,9 @@ static int mlx5e_set_rxnfc(struct net_device
> *dev, struct ethtool_rxnfc *cmd)
>  }
>  
>  const struct ethtool_ops mlx5e_ethtool_ops = {
> +	.supported_coalesce_params = ETHTOOL_COALESCE_USECS |
> +				     ETHTOOL_COALESCE_MAX_FRAMES |
> +				     ETHTOOL_COALESCE_USE_ADAPTIVE,
>  	.get_drvinfo       = mlx5e_get_drvinfo,
>  	.get_link          = ethtool_op_get_link,
>  	.get_strings       = mlx5e_get_strings,
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c
> b/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c
> index 1a8897f80547..c506143c8559 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c
> @@ -376,6 +376,9 @@ static int
> mlx5e_uplink_rep_set_link_ksettings(struct net_device *netdev,
>  }
>  
>  static const struct ethtool_ops mlx5e_rep_ethtool_ops = {
> +	.supported_coalesce_params = ETHTOOL_COALESCE_USECS |
> +				     ETHTOOL_COALESCE_MAX_FRAMES |
> +				     ETHTOOL_COALESCE_USE_ADAPTIVE,
>  	.get_drvinfo	   = mlx5e_rep_get_drvinfo,
>  	.get_link	   = ethtool_op_get_link,
>  	.get_strings       = mlx5e_rep_get_strings,
> @@ -392,6 +395,9 @@ static const struct ethtool_ops
> mlx5e_rep_ethtool_ops = {
>  };
>  
>  static const struct ethtool_ops mlx5e_uplink_rep_ethtool_ops = {
> +	.supported_coalesce_params = ETHTOOL_COALESCE_USECS |
> +				     ETHTOOL_COALESCE_MAX_FRAMES |
> +				     ETHTOOL_COALESCE_USE_ADAPTIVE,
>  	.get_drvinfo	   = mlx5e_uplink_rep_get_drvinfo,
>  	.get_link	   = ethtool_op_get_link,
>  	.get_strings       = mlx5e_rep_get_strings,
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/ipoib/ethtool.c
> b/drivers/net/ethernet/mellanox/mlx5/core/ipoib/ethtool.c
> index 90cb50fe17fd..1eef66ee849e 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/ipoib/ethtool.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/ipoib/ethtool.c
> @@ -235,6 +235,9 @@ static int mlx5i_get_link_ksettings(struct
> net_device *netdev,
>  }
>  
>  const struct ethtool_ops mlx5i_ethtool_ops = {
> +	.supported_coalesce_params = ETHTOOL_COALESCE_USECS |
> +				     ETHTOOL_COALESCE_MAX_FRAMES |
> +				     ETHTOOL_COALESCE_USE_ADAPTIVE,
>  	.get_drvinfo        = mlx5i_get_drvinfo,
>  	.get_strings        = mlx5i_get_strings,
>  	.get_sset_count     = mlx5i_get_sset_count,