netdev - Re: [PATCH net-next v3 3/6] cxgb4/chcr: complete record tx handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 5 Mar 2020 08:49:13 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Rohit Maheshwari <rohitm@...lsio.com>
Cc:     kbuild-all@...ts.01.org, netdev@...r.kernel.org,
        davem@...emloft.net, herbert@...dor.apana.org.au
Subject: Re: [PATCH net-next v3 3/6] cxgb4/chcr: complete record tx handling

Hi Rohit,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on net-next/master]
[also build test ERROR on cryptodev/master crypto/master linus/master v5.6-rc4 next-20200304]
[cannot apply to ipvs/master]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Rohit-Maheshwari/cxgb4-chcr-ktls-tx-offload-support-on-T6-adapter/20200229-163122
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git e955376277839db92774ec24d559ab42442b95fc
config: i386-randconfig-d003-20200304 (attached as .config)
compiler: gcc-7 (Debian 7.5.0-5) 7.5.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers/net/ethernet/chelsio/cxgb4/sge.c: In function 'cxgb4_eth_xmit':
>> drivers/net/ethernet/chelsio/cxgb4/sge.c:1411:50: error: 'struct sk_buff' has no member named 'decrypted'
     if ((xfrm_offload(skb) && !ssi->gso_size) || skb->decrypted)
                                                     ^~

vim +1411 drivers/net/ethernet/chelsio/cxgb4/sge.c

  1376	
  1377	/**
  1378	 *	cxgb4_eth_xmit - add a packet to an Ethernet Tx queue
  1379	 *	@skb: the packet
  1380	 *	@dev: the egress net device
  1381	 *
  1382	 *	Add a packet to an SGE Ethernet Tx queue.  Runs with softirqs disabled.
  1383	 */
  1384	static netdev_tx_t cxgb4_eth_xmit(struct sk_buff *skb, struct net_device *dev)
  1385	{
  1386		enum cpl_tx_tnl_lso_type tnl_type = TX_TNL_TYPE_OPAQUE;
  1387		bool ptp_enabled = is_ptp_enabled(skb, dev);
  1388		unsigned int last_desc, flits, ndesc;
  1389		u32 wr_mid, ctrl0, op, sgl_off = 0;
  1390		const struct skb_shared_info *ssi;
  1391		int len, qidx, credits, ret, left;
  1392		struct tx_sw_desc *sgl_sdesc;
  1393		struct fw_eth_tx_eo_wr *eowr;
  1394		struct fw_eth_tx_pkt_wr *wr;
  1395		struct cpl_tx_pkt_core *cpl;
  1396		const struct port_info *pi;
  1397		bool immediate = false;
  1398		u64 cntrl, *end, *sgl;
  1399		struct sge_eth_txq *q;
  1400		unsigned int chip_ver;
  1401		struct adapter *adap;
  1402	
  1403		ret = cxgb4_validate_skb(skb, dev, ETH_HLEN);
  1404		if (ret)
  1405			goto out_free;
  1406	
  1407		pi = netdev_priv(dev);
  1408		adap = pi->adapter;
  1409		ssi = skb_shinfo(skb);
  1410	#if defined(CONFIG_CHELSIO_IPSEC_INLINE) || defined(CONFIG_CHELSIO_TLS_DEVICE)
> 1411		if ((xfrm_offload(skb) && !ssi->gso_size) || skb->decrypted)
  1412			return adap->uld[CXGB4_ULD_CRYPTO].tx_handler(skb, dev);
  1413	#endif /* CHELSIO_IPSEC_INLINE || CONFIG_CHELSIO_TLS_DEVICE */
  1414	
  1415		qidx = skb_get_queue_mapping(skb);
  1416		if (ptp_enabled) {
  1417			spin_lock(&adap->ptp_lock);
  1418			if (!(adap->ptp_tx_skb)) {
  1419				skb_shinfo(skb)->tx_flags |= SKBTX_IN_PROGRESS;
  1420				adap->ptp_tx_skb = skb_get(skb);
  1421			} else {
  1422				spin_unlock(&adap->ptp_lock);
  1423				goto out_free;
  1424			}
  1425			q = &adap->sge.ptptxq;
  1426		} else {
  1427			q = &adap->sge.ethtxq[qidx + pi->first_qset];
  1428		}
  1429		skb_tx_timestamp(skb);
  1430	
  1431		reclaim_completed_tx(adap, &q->q, -1, true);
  1432		cntrl = TXPKT_L4CSUM_DIS_F | TXPKT_IPCSUM_DIS_F;
  1433	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (35881 bytes)