netdev - Re: [PATCH net-next v3 6/6] cxgb4/chcr: Add ipv6 support and statistics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ed17e70d-464f-445f-5d27-157988f7dee1@chelsio.com>
Date:   Thu, 5 Mar 2020 16:59:06 +0530
From:   rohit maheshwari <rohitm@...lsio.com>
To:     Boris Pismenny <borisp@...lanox.com>, netdev@...r.kernel.org,
        davem@...emloft.net, herbert@...dor.apana.org.au
Cc:     secdev@...lsio.com, varun@...lsio.com, kuba@...nel.org
Subject: Re: [PATCH net-next v3 6/6] cxgb4/chcr: Add ipv6 support and
 statistics

Hi Boris,

On 04/03/20 10:35 PM, Boris Pismenny wrote:
>
> On 29/02/2020 3:24, Rohit Maheshwari wrote:
>> Adding ipv6 support and ktls related statistics.
>>
>> v1->v2:
>> - aaded blank lines at 2 places.
>>
>> Signed-off-by: Rohit Maheshwari <rohitm@...lsio.com>
>> ---
> ...
>
>> +	seq_puts(seq, "\nChelsio KTLS Crypto Accelerator Stats\n");
>> +	seq_printf(seq, "KTLS connection opened:                  %10u\n",
>> +		   atomic_read(&adap->chcr_stats.ktls_tx_connection_open));
>> +	seq_printf(seq, "KTLS connection failed:                  %10u\n",
>> +		   atomic_read(&adap->chcr_stats.ktls_tx_connection_fail));
>> +	seq_printf(seq, "KTLS connection closed:                  %10u\n",
>> +		   atomic_read(&adap->chcr_stats.ktls_tx_connection_close));
>> +	seq_printf(seq, "KTLS Tx pkt received from stack:         %10u\n",
>> +		   atomic_read(&adap->chcr_stats.ktls_tx_pkts_received));
>> +	seq_printf(seq, "KTLS tx records send:                    %10u\n",
>> +		   atomic_read(&adap->chcr_stats.ktls_tx_send_records));
>> +	seq_printf(seq, "KTLS tx partial start of records:        %10u\n",
>> +		   atomic_read(&adap->chcr_stats.ktls_tx_start_pkts));
>> +	seq_printf(seq, "KTLS tx partial middle of records:       %10u\n",
>> +		   atomic_read(&adap->chcr_stats.ktls_tx_middle_pkts));
>> +	seq_printf(seq, "KTLS tx partial end of record:           %10u\n",
>> +		   atomic_read(&adap->chcr_stats.ktls_tx_end_pkts));
>> +	seq_printf(seq, "KTLS tx complete records:                %10u\n",
>> +		   atomic_read(&adap->chcr_stats.ktls_tx_complete_pkts));
>> +	seq_printf(seq, "KTLS tx trim pkts :                      %10u\n",
>> +		   atomic_read(&adap->chcr_stats.ktls_tx_trimmed_pkts));
>> +	seq_printf(seq, "KTLS tx retransmit packets:              %10u\n",
>> +		   atomic_read(&adap->chcr_stats.ktls_tx_retransmit_pkts));
>> +#endif
> Please confirm to TLS offload documentation or update it if you think it
> is necessary.

I'll take care of it in v4 patch.