netdev - RE: [PATCH bpf-next v3 05/12] bpf: sockmap: move generic sockmap hooks from BPF TCP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5e626c0fa6eee_17502acca07205b448@john-XPS-13-9370.notmuch>
Date:   Fri, 06 Mar 2020 07:28:15 -0800
From:   John Fastabend <john.fastabend@...il.com>
To:     Lorenz Bauer <lmb@...udflare.com>, john.fastabend@...il.com,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Jakub Sitnicki <jakub@...udflare.com>,
        Lorenz Bauer <lmb@...udflare.com>,
        Eric Dumazet <edumazet@...gle.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Alexey Kuznetsov <kuznet@....inr.ac.ru>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>
Cc:     kernel-team@...udflare.com, netdev@...r.kernel.org,
        bpf@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: RE: [PATCH bpf-next v3 05/12] bpf: sockmap: move generic sockmap
 hooks from BPF TCP

Lorenz Bauer wrote:
> The init, close and unhash handlers from TCP sockmap are generic,
> and can be reused by UDP sockmap. Move the helpers into the sockmap code
> base and expose them. This requires tcp_bpf_get_proto and tcp_bpf_clone to
> be conditional on BPF_STREAM_PARSER.
> 
> The moved functions are unmodified, except that sk_psock_unlink is
> renamed to sock_map_unlink to better match its behaviour.
> 
> Signed-off-by: Lorenz Bauer <lmb@...udflare.com>
> ---
>  include/linux/bpf.h   |   4 +-
>  include/linux/skmsg.h |  28 -----------
>  include/net/tcp.h     |  15 +++---
>  net/core/sock_map.c   | 106 ++++++++++++++++++++++++++++++++++++++++--
>  net/ipv4/tcp_bpf.c    |  84 ++-------------------------------
>  5 files changed, 118 insertions(+), 119 deletions(-)

Acked-by: John Fastabend <john.fastabend@...il.com>