netdev - RE: [PATCH bpf-next v3 11/12] selftests: bpf: enable UDP sockmap reuseport tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5e626eb118da1_17502acca07205b42f@john-XPS-13-9370.notmuch>
Date:   Fri, 06 Mar 2020 07:39:29 -0800
From:   John Fastabend <john.fastabend@...il.com>
To:     Lorenz Bauer <lmb@...udflare.com>, john.fastabend@...il.com,
        Shuah Khan <shuah@...nel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>
Cc:     kernel-team@...udflare.com, Lorenz Bauer <lmb@...udflare.com>,
        linux-kselftest@...r.kernel.org, netdev@...r.kernel.org,
        bpf@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: RE: [PATCH bpf-next v3 11/12] selftests: bpf: enable UDP sockmap
 reuseport tests

Lorenz Bauer wrote:
> Remove the guard that disables UDP tests now that sockmap
> has support for them.
> 
> Signed-off-by: Lorenz Bauer <lmb@...udflare.com>
> ---
>  tools/testing/selftests/bpf/prog_tests/select_reuseport.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/tools/testing/selftests/bpf/prog_tests/select_reuseport.c b/tools/testing/selftests/bpf/prog_tests/select_reuseport.c
> index a1dd13b34d4b..821b4146b7b6 100644
> --- a/tools/testing/selftests/bpf/prog_tests/select_reuseport.c
> +++ b/tools/testing/selftests/bpf/prog_tests/select_reuseport.c
> @@ -805,12 +805,6 @@ static void test_config(int sotype, sa_family_t family, bool inany)
>  	char s[MAX_TEST_NAME];
>  	const struct test *t;
>  
> -	/* SOCKMAP/SOCKHASH don't support UDP yet */
> -	if (sotype == SOCK_DGRAM &&
> -	    (inner_map_type == BPF_MAP_TYPE_SOCKMAP ||
> -	     inner_map_type == BPF_MAP_TYPE_SOCKHASH))
> -		return;
> -
>  	for (t = tests; t < tests + ARRAY_SIZE(tests); t++) {
>  		if (t->need_sotype && t->need_sotype != sotype)
>  			continue; /* test not compatible with socket type */
> -- 
> 2.20.1
> 

Acked-by: John Fastabend <john.fastabend@...il.com>