netdev - Re: [net-next 05/16] ice: Add support for tunnel offloads

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200305172245.37a4b3d2@kicinski-fedora-PC1C0HJN>
Date:   Thu, 5 Mar 2020 17:22:45 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>
Cc:     "Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
        "nhorman@...hat.com" <nhorman@...hat.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "Bowers, AndrewX" <andrewx.bowers@...el.com>,
        "sassmann@...hat.com" <sassmann@...hat.com>,
        "Tieman, Henry W" <henry.w.tieman@...el.com>
Subject: Re: [net-next 05/16] ice: Add support for tunnel offloads

On Fri, 6 Mar 2020 01:08:45 +0000 Nguyen, Anthony L wrote:
> > > +	status = ice_create_tunnel(&pf->hw, tnl_type, port);
> > > +	if (status == ICE_ERR_ALREADY_EXISTS)
> > > +		dev_dbg(ice_pf_to_dev(pf), "port %d already exists in
> > > UDP tunnels list\n",
> > > +			port);
> > > +	else if (status == ICE_ERR_OUT_OF_RANGE)
> > > +		netdev_err(netdev, "Max tunneled UDP ports reached,
> > > port %d not added\n",
> > > +			   port);  
> > 
> > error is probably a little much for resource exhaustion since it's
> > not
> > going to cause any problem other than a slow down?  
> 
> Correct, just a slow down. A warning then or did you prefer a dbg?

No preference.