netdev - Re: [PATCH v3 net-next 7/8] ionic: add support for device id 0x1004

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5ac3562b-47b1-a684-c7f2-61da1a233859@pensando.io>
Date:   Fri, 6 Mar 2020 12:32:51 -0800
From:   Shannon Nelson <snelson@...sando.io>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     netdev@...r.kernel.org, davem@...emloft.net
Subject: Re: [PATCH v3 net-next 7/8] ionic: add support for device id 0x1004

On 3/6/20 10:20 AM, Jakub Kicinski wrote:
> On Thu, 5 Mar 2020 23:43:44 -0800 Shannon Nelson wrote:
>> Yes, and if we were just writing registers, that would make sense. When
>> I can get to it I do intend to try expand our use of the devlink
>> interfaces where it will work for us.
> Yes, please do that.
>
>> However, this device id does exist on some of the DSC configurations,
>> and I'd prefer to explicitly acknowledge its existence in the driver and
>> perhaps keep better control over it, whether or not it gets used by our
>> 3rd party tool, rather than leave it as some obscure port for someone to
>> "discover".
> I understand, but disagree. Your driver can certainly bind to that
> management device but it has to be for the internal use of the kernel.
> You shouldn't just expose that FW interface right out to user space as
> a netdev.
So for now the driver should simply capture and configure the PCI 
device, but stop at that point and not setup a netdev.  This would leave 
the device available for devlink commands.

If that sounds reasonable to you, I'll add it and respin the patchset.

sln