netdev - Re: [PATCH net] bonding/alb: make sure arp header is pulled before accessing it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 06 Mar 2020 22:01:23 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     edumazet@...gle.com
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com,
        syzkaller@...glegroups.com, j.vosburgh@...il.com,
        vfalico@...il.com, andy@...yhouse.net
Subject: Re: [PATCH net] bonding/alb: make sure arp header is pulled before
 accessing it

From: Eric Dumazet <edumazet@...gle.com>
Date: Wed,  4 Mar 2020 09:32:16 -0800

> Similar to commit 38f88c454042 ("bonding/alb: properly access headers
> in bond_alb_xmit()"), we need to make sure arp header was pulled
> in skb->head before blindly accessing it in rlb_arp_xmit().
> 
> Remove arp_pkt() private helper, since it is more readable/obvious
> to have the following construct back to back :
> 
> 	if (!pskb_network_may_pull(skb, sizeof(*arp)))
> 		return NULL;
> 	arp = (struct arp_pkt *)skb_network_header(skb);
> 
> syzbot reported :
 ...
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: syzbot <syzkaller@...glegroups.com>

Applied and queued up for -stable, thanks Eric.