netdev - Re: [PATCH] ip link: Prevent duplication of table id for vrf tables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c8145b59-6f26-ab55-c33a-362fe87fd59b@candelatech.com>
Date:   Mon, 9 Mar 2020 07:04:37 -0700
From:   Ben Greear <greearb@...delatech.com>
To:     David Ahern <dsahern@...il.com>,
        Donald Sharp <sharpd@...ulusnetworks.com>,
        netdev@...r.kernel.org, dsahern@...nel.org,
        roopa@...ulusnetworks.com, sworley@...ulusnetworks.com
Subject: Re: [PATCH] ip link: Prevent duplication of table id for vrf tables



On 03/08/2020 07:22 PM, David Ahern wrote:
> On 3/7/20 1:59 PM, Donald Sharp wrote:
>> Creation of different vrf's with duplicate table id's creates
>> a situation where two different routing entities believe
>> they have exclusive access to a particular table.  This
>> leads to situations where different routing processes
>> clash for control of a route due to inadvertent table
>> id overlap.  Prevent end user from making this mistake
>> on accident.
>
> I get the pain, but it is a user management problem and ip is but one
> tool. I think at most ip warns the user about the table duplication; it
> can't fail the create.

You could default 'ip' to use the safe mode, and allow a --force option if
there is some reason why it should be allowed?

Thanks,
Ben

-- 
Ben Greear <greearb@...delatech.com>
Candela Technologies Inc  http://www.candelatech.com