lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 9 Mar 2020 11:42:40 -0400
From:   Willem de Bruijn <>
To:     Willem de Bruijn <>
Cc:     Network Development <>,
        David Miller <>,
        "Michael S. Tsirkin" <>
Subject: Re: [PATCH net] net/packet: tpacket_rcv: do not increment ring index
 on drop

On Mon, Mar 9, 2020 at 11:34 AM Willem de Bruijn
<> wrote:
> From: Willem de Bruijn <>
> In one error case, tpacket_rcv drops packets after incrementing the
> ring producer index.
> If this happens, it does not update tp_status to TP_STATUS_USER and
> thus the reader is stalled for an iteration of the ring, causing out
> of order arrival.
> The only such error path is when virtio_net_hdr_from_skb fails due
> to encountering an unknown GSO type.
> Signed-off-by: Willem de Bruijn <>

Fixes: bfd5f4a3d605 ("packet: Add GSO/csum offload support.")

I forgot to add the Fixes tag, sorry. This goes back to the
introduction of GSO support for virtio_net.

The discussion then explicitly arrived at deciding to fail on an
unknown type (SKB_GSO_FCOE). Which is why I asked the question here
whether we want to revisit that choice or leave as is.

Powered by blists - more mailing lists