netdev - Re: [PATCH net-next] net: sched: pie: change tc_pie

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200309151957.313e0428@kicinski-fedora-PC1C0HJN>
Date:   Mon, 9 Mar 2020 15:19:57 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Leslie Monis <lesliemonis@...il.com>
Cc:     Linux NetDev <netdev@...r.kernel.org>,
        David Miller <davem@...emloft.net>,
        "Mohit P . Tahiliani" <tahiliani@...k.edu.in>,
        Gautam Ramakrishnan <gautamramk@...il.com>,
        Eric Dumazet <edumazet@...gle.com>
Subject: Re: [PATCH net-next] net: sched: pie: change tc_pie_xstats->prob

On Tue, 10 Mar 2020 00:40:33 +0530 Leslie Monis wrote:
> Commit 105e808c1da2 ("pie: remove pie_vars->accu_prob_overflows")
> changes the scale of probability values in PIE from (2^64 - 1) to
> (2^56 - 1). This affects the precision of tc_pie_xstats->prob in
> user space.
> 
> This patch ensures user space is unaffected.
> 
> Suggested-by: Eric Dumazet <edumazet@...gle.com>
> Signed-off-by: Leslie Monis <lesliemonis@...il.com>

Thanks, I was looking out for user space changes during review but it
was too hard to catch this until the iproute2 patch surfaced :(

I'd be good to post the user space changes along the kernel side.
iproute2 maintainers just wait for the kernel part to land in that case.